Skip to content

Commit aca7af5

Browse files
Add title to column options. Fixes #52141 (#53299)
# Add title to column options In QuickGrid, adds a title attribute to the column options button. Required for accessibility. ## Description Attaches the title "Column options" to the column options button. Fixes the "Buttons must have discernible text" accessibility requirement. Fixes #52141 ## Customer Impact Previously the button only showed an icon, which is not helpful for screen readers. After this PR you can hover to see the tooltip, and it may be read by assistive technologies. ## Regression? - [ ] Yes - [x] No [If yes, specify the version the behavior has regressed from] ## Risk - [ ] High - [ ] Medium - [x] Low It's literally just adding an HTML attribute that has no other effect. ## Verification - [x] Manual (required) - [ ] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A
1 parent 5a57a21 commit aca7af5

File tree

1 file changed

+2
-2
lines changed
  • src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/Columns

1 file changed

+2
-2
lines changed

src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/Columns/ColumnBase.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
{
2020
@if (ColumnOptions is not null && (Align != Align.Right && Align != Align.End))
2121
{
22-
<button class="col-options-button" type="button" @onclick="@(() => Grid.ShowColumnOptionsAsync(this))"></button>
22+
<button class="col-options-button" type="button" title="Column options" @onclick="@(() => Grid.ShowColumnOptionsAsync(this))"></button>
2323
}
2424

2525
if (Sortable.HasValue ? Sortable.Value : IsSortableByDefault())
@@ -38,7 +38,7 @@
3838

3939
@if (ColumnOptions is not null && (Align == Align.Right || Align == Align.End))
4040
{
41-
<button class="col-options-button" type="button" @onclick="@(() => Grid.ShowColumnOptionsAsync(this))"></button>
41+
<button class="col-options-button" type="button" title="Column options" @onclick="@(() => Grid.ShowColumnOptionsAsync(this))"></button>
4242
}
4343
}
4444
}

0 commit comments

Comments
 (0)