Skip to content

Add title to column options. Fixes #52141 #53299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Jan 11, 2024

Add title to column options

In QuickGrid, adds a title attribute to the column options button. Required for accessibility.

Description

Attaches the title "Column options" to the column options button. Fixes the "Buttons must have discernible text" accessibility requirement.

Fixes #52141

Customer Impact

Previously the button only showed an icon, which is not helpful for screen readers. After this PR you can hover to see the tooltip, and it may be read by assistive technologies.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

It's literally just adding an HTML attribute that has no other effect.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 11, 2024
@ghost ghost added this to the 8.0.x milestone Jan 11, 2024
@ghost
Copy link

ghost commented Jan 11, 2024

Hi @SteveSandersonMS. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@SteveSandersonMS
Copy link
Member Author

@mkArtak Is this tell-mode?

@SteveSandersonMS SteveSandersonMS marked this pull request as ready for review January 11, 2024 10:40
@SteveSandersonMS SteveSandersonMS requested a review from a team as a code owner January 11, 2024 10:40
@SteveSandersonMS
Copy link
Member Author

/backport to main

Copy link
Contributor

Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/7490251213

@mkArtak
Copy link
Contributor

mkArtak commented Jan 11, 2024

@mkArtak Is this tell-mode?

No. Will send the request today.

@SteveSandersonMS SteveSandersonMS added the Servicing-consider Shiproom approval is required for the issue label Jan 11, 2024
@ghost
Copy link

ghost commented Jan 11, 2024

Hi @SteveSandersonMS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 12, 2024
@ghost
Copy link

ghost commented Jan 12, 2024

Hi @SteveSandersonMS. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@mkArtakMSFT mkArtakMSFT merged commit aca7af5 into release/8.0 Jan 16, 2024
@mkArtakMSFT mkArtakMSFT deleted the stevesa/fix-column-options-title branch January 16, 2024 16:41
@ghost ghost modified the milestones: 8.0.x, 8.0.2 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants