Use AppendJoin(...) instead of Append(string.Join(...)) on StringBuilder (#18007)

Author: Kahbazi

src/Http/Routing/src/CompositeEndpointDataSource.cs

@@ -165,7 +165,7 @@ private string DebuggerDisplayString
                         template = string.IsNullOrEmpty(template) ? "\"\"" : template;
                         sb.Append(template);
                         sb.Append(", Defaults: new { ");
-                        sb.Append(string.Join(", ", FormatValues(routeEndpoint.RoutePattern.Defaults)));
+                        sb.AppendJoin(", ", FormatValues(routeEndpoint.RoutePattern.Defaults));
                         sb.Append(" }");
                         var routeNameMetadata = routeEndpoint.Metadata.GetMetadata<IRouteNameMetadata>();
                         sb.Append(", Route Name: ");
@@ -174,7 +174,7 @@ private string DebuggerDisplayString
                         if (routeValues.Count > 0)
                         {
                             sb.Append(", Required Values: new { ");
-                            sb.Append(string.Join(", ", FormatValues(routeValues)));
+                            sb.AppendJoin(", ", FormatValues(routeValues));
                             sb.Append(" }");
                         }
                         sb.Append(", Order: ");
@@ -184,7 +184,7 @@ private string DebuggerDisplayString
                         if (httpMethodMetadata != null)
                         {
                             sb.Append(", Http Methods: ");
-                            sb.Append(string.Join(", ", httpMethodMetadata.HttpMethods));
+                            sb.AppendJoin(", ", httpMethodMetadata.HttpMethods);
                         }
                         sb.Append(", Display Name: ");
                         sb.Append(routeEndpoint.DisplayName);

src/Http/Routing/src/Matching/DfaNode.cs

@@ -121,7 +121,7 @@ private string DebuggerToString()
             builder.Append(" c: ");
             if (Literals != null)
             {
-                builder.Append(string.Join(", ", Literals.Select(kvp => $"{kvp.Key}->({FormatNode(kvp.Value)})")));
+                builder.AppendJoin(", ", Literals.Select(kvp => $"{kvp.Key}->({FormatNode(kvp.Value)})"));
             }
             return builder.ToString();
 

src/Http/Routing/src/Matching/DictionaryJumpTable.cs

@@ -50,7 +50,7 @@ public override string DebuggerToString()
             var builder = new StringBuilder();
             builder.Append("{ ");
 
-            builder.Append(string.Join(", ", _dictionary.Select(kvp => $"{kvp.Key}: {kvp.Value}")));
+            builder.AppendJoin(", ", _dictionary.Select(kvp => $"{kvp.Key}: {kvp.Value}"));
 
             builder.Append("$+: ");
             builder.Append(_defaultDestination);

src/Http/Routing/src/Matching/LinearSearchJumpTable.cs

@@ -55,7 +55,7 @@ public override string DebuggerToString()
             var builder = new StringBuilder();
             builder.Append("{ ");
 
-            builder.Append(string.Join(", ", _entries.Select(e => $"{e.text}: {e.destination}")));
+            builder.AppendJoin(", ", _entries.Select(e => $"{e.text}: {e.destination}"));
 
             builder.Append("$+: ");
             builder.Append(_defaultDestination);

src/Http/Routing/src/Tree/LinkGenerationDecisionTree.cs

@@ -248,7 +248,7 @@ private void FlattenTree(Stack<string> branchStack, StringBuilder sb, DecisionTr
                 }
                 sb.Append(matchesSb.ToString());
                 sb.Append(" (Matches: ");
-                sb.Append(string.Join(", ", node.Matches.Select(m => m.Entry.RouteTemplate.TemplateText)));
+                sb.AppendJoin(", ", node.Matches.Select(m => m.Entry.RouteTemplate.TemplateText));
                 sb.AppendLine(")");
             }
 

src/Middleware/CORS/src/Infrastructure/CorsPolicy.cs

@@ -142,16 +142,16 @@ public override string ToString()
             builder.Append(", SupportsCredentials: ");
             builder.Append(SupportsCredentials);
             builder.Append(", Origins: {");
-            builder.Append(string.Join(",", Origins));
+            builder.AppendJoin(",", Origins);
             builder.Append("}");
             builder.Append(", Methods: {");
-            builder.Append(string.Join(",", Methods));
+            builder.AppendJoin(",", Methods);
             builder.Append("}");
             builder.Append(", Headers: {");
-            builder.Append(string.Join(",", Headers));
+            builder.AppendJoin(",", Headers);
             builder.Append("}");
             builder.Append(", ExposedHeaders: {");
-            builder.Append(string.Join(",", ExposedHeaders));
+            builder.AppendJoin(",", ExposedHeaders);
             builder.Append("}");
             return builder.ToString();
         }
@@ -161,4 +161,4 @@ private bool DefaultIsOriginAllowed(string origin)
             return Origins.Contains(origin, StringComparer.Ordinal);
         }
     }
-}
+}

src/Middleware/CORS/src/Infrastructure/CorsResult.cs

@@ -91,15 +91,15 @@ public override string ToString()
             builder.Append(", AllowOrigin: ");
             builder.Append(AllowedOrigin);
             builder.Append(", AllowExposedHeaders: {");
-            builder.Append(string.Join(",", AllowedExposedHeaders));
+            builder.AppendJoin(",", AllowedExposedHeaders);
             builder.Append("}");
             builder.Append(", AllowHeaders: {");
-            builder.Append(string.Join(",", AllowedHeaders));
+            builder.AppendJoin(",", AllowedHeaders);
             builder.Append("}");
             builder.Append(", AllowMethods: {");
-            builder.Append(string.Join(",", AllowedMethods));
+            builder.AppendJoin(",", AllowedMethods);
             builder.Append("}");
             return builder.ToString();
         }
     }
-}
+}

src/Shared/StackTrace/StackFrame/MethodDisplayInfo.cs

@@ -33,7 +33,7 @@ public override string ToString()
             builder.Append(GenericArguments);
 
             builder.Append("(");
-            builder.Append(string.Join(", ", Parameters.Select(p => p.ToString())));
+            builder.AppendJoin(", ", Parameters.Select(p => p.ToString()));
             builder.Append(")");
 
             if (!string.IsNullOrEmpty(SubMethod))