Reenable cert tests on helix (#20372)

HaoK · web-flow · commit cc79bcc67b23 · 2020-04-04T13:02:22.000-07:00
diff --git a/src/Components/Components/test/RendererTest.cs b/src/Components/Components/test/RendererTest.cs
@@ -2810,8 +2810,7 @@ public void CanTriggerRenderingSynchronouslyFromInsideAfterRenderCallback()
             Assert.Equal(10, component.OnAfterRenderCallCount);
         }
 
-        [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7487")]
+        [Fact]
         public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync()
         {
             // This represents the scenario where the same event handler is being triggered
diff --git a/src/Identity/ApiAuthorization.IdentityServer/test/Configuration/ConfigureSigningCredentialsTests.cs b/src/Identity/ApiAuthorization.IdentityServer/test/Configuration/ConfigureSigningCredentialsTests.cs
@@ -23,7 +23,6 @@ public class ConfigureSigningCredentialsTests
             X509KeyStorageFlags.DefaultKeySet);
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
         [FrameworkSkipCondition(RuntimeFrameworks.CLR)]
         public void Configure_AddsDevelopmentKeyFromConfiguration()
         {
@@ -64,7 +63,7 @@ public void Configure_AddsDevelopmentKeyFromConfiguration()
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public void Configure_LoadsPfxCertificateCredentialFromConfiguration()
         {
             // Arrange
@@ -94,7 +93,7 @@ public void Configure_LoadsPfxCertificateCredentialFromConfiguration()
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public void Configure_LoadsCertificateStoreCertificateCredentialFromConfiguration()
         {
             try
diff --git a/src/Identity/ApiAuthorization.IdentityServer/test/Configuration/SigningKeysLoaderTests.cs b/src/Identity/ApiAuthorization.IdentityServer/test/Configuration/SigningKeysLoaderTests.cs
@@ -59,7 +59,7 @@ public static void LoadFromStoreCert_ThrowsIfThereIsNoCertificateAvailable()
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public static void LoadFromStoreCert_SkipsCertificatesNotYetValid()
         {
             try
@@ -82,7 +82,7 @@ public static void LoadFromStoreCert_SkipsCertificatesNotYetValid()
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public static void LoadFromStoreCert_PrefersCertificatesCloserToExpirationDate()
         {
             try
@@ -105,7 +105,7 @@ public static void LoadFromStoreCert_PrefersCertificatesCloserToExpirationDate()
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public static void LoadFromStoreCert_SkipsExpiredCertificates()
         {
             try
diff --git a/src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs b/src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs
@@ -29,7 +29,7 @@ public CertificateManagerTests(ITestOutputHelper output, CertFixture fixture)
         public ITestOutputHelper Output { get; }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public void EnsureCreateHttpsCertificate_CreatesACertificate_WhenThereAreNoHttpsCertificates()
         {
             try
@@ -124,7 +124,7 @@ private void ListCertificates(ITestOutputHelper output)
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public void EnsureCreateHttpsCertificate_DoesNotCreateACertificate_WhenThereIsAnExistingHttpsCertificates()
         {
             // Arrange
@@ -154,8 +154,7 @@ public void EnsureCreateHttpsCertificate_DoesNotCreateACertificate_WhenThereIsAn
             Assert.Equal(httpsCertificate.GetCertHashString(), exportedCertificate.GetCertHashString());
         }
 
-        [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
+        [Fact]
         public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsIncorrect()
         {
             _fixture.CleanupCertificates();
@@ -170,8 +169,7 @@ public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsInc
             Assert.Empty(httpsCertificateList);
         }
 
-        [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
+        [Fact]
         public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersionField()
         {
             _fixture.CleanupCertificates();
@@ -188,7 +186,7 @@ public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersio
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public void EnsureCreateHttpsCertificate_ReturnsValidIfVersionIsZero()
         {
             _fixture.CleanupCertificates();
@@ -203,7 +201,7 @@ public void EnsureCreateHttpsCertificate_ReturnsValidIfVersionIsZero()
         }
 
         [ConditionalFact]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
         public void EnsureCreateHttpsCertificate_ReturnValidIfCertIsNewer()
         {
             _fixture.CleanupCertificates();

Original file line number	Diff line number	Diff line change
`@@ -2810,8 +2810,7 @@ public void CanTriggerRenderingSynchronouslyFromInsideAfterRenderCallback()`
`2810`	`2810`	`Assert.Equal(10, component.OnAfterRenderCallCount);`
`2811`	`2811`	`}`
`2812`	`2812`
`2813`		`- [ConditionalFact]`
`2814`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7487")]`
	`2813`	`+ [Fact]`
`2815`	`2814`	`public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync()`
`2816`	`2815`	`{`
`2817`	`2816`	`// This represents the scenario where the same event handler is being triggered`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ public class ConfigureSigningCredentialsTests`
`23`	`23`	`X509KeyStorageFlags.DefaultKeySet);`
`24`	`24`
`25`	`25`	`[ConditionalFact]`
`26`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]`
`27`	`26`	`[FrameworkSkipCondition(RuntimeFrameworks.CLR)]`
`28`	`27`	`public void Configure_AddsDevelopmentKeyFromConfiguration()`
`29`	`28`	`{`
`@@ -64,7 +63,7 @@ public void Configure_AddsDevelopmentKeyFromConfiguration()`
`64`	`63`	`}`
`65`	`64`
`66`	`65`	`[ConditionalFact]`
`67`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]`
	`66`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`68`	`67`	`public void Configure_LoadsPfxCertificateCredentialFromConfiguration()`
`69`	`68`	`{`
`70`	`69`	`// Arrange`
`@@ -94,7 +93,7 @@ public void Configure_LoadsPfxCertificateCredentialFromConfiguration()`
`94`	`93`	`}`
`95`	`94`
`96`	`95`	`[ConditionalFact]`
`97`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]`
	`96`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`98`	`97`	`public void Configure_LoadsCertificateStoreCertificateCredentialFromConfiguration()`
`99`	`98`	`{`
`100`	`99`	`try`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public static void LoadFromStoreCert_ThrowsIfThereIsNoCertificateAvailable()`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`[ConditionalFact]`
`62`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]`
	`62`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`63`	`63`	`public static void LoadFromStoreCert_SkipsCertificatesNotYetValid()`
`64`	`64`	`{`
`65`	`65`	`try`
`@@ -82,7 +82,7 @@ public static void LoadFromStoreCert_SkipsCertificatesNotYetValid()`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`[ConditionalFact]`
`85`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]`
	`85`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`86`	`86`	`public static void LoadFromStoreCert_PrefersCertificatesCloserToExpirationDate()`
`87`	`87`	`{`
`88`	`88`	`try`
`@@ -105,7 +105,7 @@ public static void LoadFromStoreCert_PrefersCertificatesCloserToExpirationDate()`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`[ConditionalFact]`
`108`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]`
	`108`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`109`	`109`	`public static void LoadFromStoreCert_SkipsExpiredCertificates()`
`110`	`110`	`{`
`111`	`111`	`try`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public CertificateManagerTests(ITestOutputHelper output, CertFixture fixture)`
`29`	`29`	`public ITestOutputHelper Output { get; }`
`30`	`30`
`31`	`31`	`[ConditionalFact]`
`32`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]`
	`32`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`33`	`33`	`public void EnsureCreateHttpsCertificate_CreatesACertificate_WhenThereAreNoHttpsCertificates()`
`34`	`34`	`{`
`35`	`35`	`try`
`@@ -124,7 +124,7 @@ private void ListCertificates(ITestOutputHelper output)`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`[ConditionalFact]`
`127`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]`
	`127`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`128`	`128`	`public void EnsureCreateHttpsCertificate_DoesNotCreateACertificate_WhenThereIsAnExistingHttpsCertificates()`
`129`	`129`	`{`
`130`	`130`	`// Arrange`
`@@ -154,8 +154,7 @@ public void EnsureCreateHttpsCertificate_DoesNotCreateACertificate_WhenThereIsAn`
`154`	`154`	`Assert.Equal(httpsCertificate.GetCertHashString(), exportedCertificate.GetCertHashString());`
`155`	`155`	`}`
`156`	`156`
`157`		`- [ConditionalFact]`
`158`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]`
	`157`	`+ [Fact]`
`159`	`158`	`public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsIncorrect()`
`160`	`159`	`{`
`161`	`160`	`_fixture.CleanupCertificates();`
`@@ -170,8 +169,7 @@ public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsInc`
`170`	`169`	`Assert.Empty(httpsCertificateList);`
`171`	`170`	`}`
`172`	`171`
`173`		`- [ConditionalFact]`
`174`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]`
	`172`	`+ [Fact]`
`175`	`173`	`public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersionField()`
`176`	`174`	`{`
`177`	`175`	`_fixture.CleanupCertificates();`
`@@ -188,7 +186,7 @@ public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersio`
`188`	`186`	`}`
`189`	`187`
`190`	`188`	`[ConditionalFact]`
`191`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]`
	`189`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`192`	`190`	`public void EnsureCreateHttpsCertificate_ReturnsValidIfVersionIsZero()`
`193`	`191`	`{`
`194`	`192`	`_fixture.CleanupCertificates();`
`@@ -203,7 +201,7 @@ public void EnsureCreateHttpsCertificate_ReturnsValidIfVersionIsZero()`
`203`	`201`	`}`
`204`	`202`
`205`	`203`	`[ConditionalFact]`
`206`		`- [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]`
	`204`	`+ [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]`
`207`	`205`	`public void EnsureCreateHttpsCertificate_ReturnValidIfCertIsNewer()`
`208`	`206`	`{`
`209`	`207`	`_fixture.CleanupCertificates();`