Skip to content

Reenable cert tests on helix #20372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 4, 2020
Merged

Reenable cert tests on helix #20372

merged 9 commits into from
Apr 4, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Mar 31, 2020

No description provided.

@ghost ghost added the area-identity Includes: Identity and providers label Mar 31, 2020
@HaoK
Copy link
Member Author

HaoK commented Apr 1, 2020

Most of the cert tests only fail on OSX now and pass on all other queues

@HaoK HaoK marked this pull request as ready for review April 1, 2020 22:07
@HaoK HaoK requested a review from SteveSandersonMS as a code owner April 1, 2020 22:08
@HaoK HaoK requested a review from a team April 1, 2020 22:08
@dougbu
Copy link
Contributor

dougbu commented Apr 2, 2020

What action was taken to ensure non-macOS cert tests are now reliable?

@HaoK
Copy link
Member Author

HaoK commented Apr 2, 2020

This isn't actually addressing any existing cert issues, this was just enabling tests that are currently working. This also has nothing to do with the template/cert test issues... these are just framework level tests that are exercising cert code, most of them still don't work on OSX, but some are passing on the other queues so they should be enabled

@HaoK HaoK merged commit cc79bcc into master Apr 4, 2020
@HaoK HaoK deleted the haok/helix/cert branch April 4, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants