feedback

Author: alefranz

src/Middleware/HeaderPropagation/src/HeaderPropagationMessageHandler.cs

@@ -49,7 +49,7 @@ protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage reques
                 var message =
                     $"The {nameof(HeaderPropagationValues)}.{nameof(HeaderPropagationValues.Headers)} property has not been " +
                     $"initialized. Register the header propagation middleware by adding 'app.{nameof(HeaderPropagationApplicationBuilderExtensions.UseHeaderPropagation)}()' " +
-                    $"in the 'Configure(...)' method. Also, do not use an HttpClient with header propagation outside of an incoming HTTP request.";
+                    $"in the 'Configure(...)' method. Header propagation can only be used within the context of an HTTP request.";
                 throw new InvalidOperationException(message);
             }
 

src/Middleware/HeaderPropagation/test/HeaderPropagationIntegrationTest.cs

@@ -64,8 +64,8 @@ public async Task HeaderPropagation_WithoutMiddleware_Throws()
             Assert.IsType<InvalidOperationException>(captured);
             Assert.Equal(
                 "The HeaderPropagationValues.Headers property has not been initialized. Register the header propagation middleware " +
-                "by adding 'app.UseHeaderPropagation()' in the 'Configure(...)' method. Also, do not use an HttpClient with header " +
-                "propagation outside of an incoming HTTP request.",
+                "by adding 'app.UseHeaderPropagation()' in the 'Configure(...)' method. Header propagation can only be used within " +
+                "the context of an HTTP request.",
                 captured.Message);
         }
 
@@ -81,15 +81,13 @@ public async Task HeaderPropagation_OutsideOfIncomingRequest_Throws()
             });
             var serviceProvider = services.BuildServiceProvider();
 
-            // Act
+            // Act & Assert
             var client = serviceProvider.GetRequiredService<IHttpClientFactory>().CreateClient("test");
             var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => client.GetAsync("http://localhost/"));
-
-            // Assert
             Assert.Equal(
                 "The HeaderPropagationValues.Headers property has not been initialized. Register the header propagation middleware " +
-                "by adding 'app.UseHeaderPropagation()' in the 'Configure(...)' method. Also, do not use an HttpClient with header " +
-                "propagation outside of an incoming HTTP request.",
+                "by adding 'app.UseHeaderPropagation()' in the 'Configure(...)' method. Header propagation can only be used within " +
+                "the context of an HTTP request.",
                 exception.Message);
         }