Skip to content

[automated] Merge branch 'release/2.2' => 'master' #10023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 8, 2019

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/2.2 branch which have not been merged yet to master. I'm a robot and am configured to help you automatically keep master up to date, so I've opened this PR.

This PR merges commits made on release/2.2 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/2.2
git pull --ff-only
git checkout master
git pull --ff-only
git merge --no-ff release/2.2

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-master
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-master

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/2.2-to-master'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/2.2-to-master master
git pull https://github.com/dotnet-maestro-bot/AspNetCore merge/release/2.2-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/AspNetCore merge/release/2.2-to-master
or if you are using SSH
git checkout -b merge/release/2.2-to-master master
git pull [email protected]:dotnet-maestro-bot/AspNetCore merge/release/2.2-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/AspNetCore merge/release/2.2-to-master

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

dougbu added 4 commits May 6, 2019 15:04
- aspnet/AspNetCore-Internal#1649
- remove `$(StartArguments}` from project; conflicts with `--update`
- support v3 source _automatically_ when not using `--update`
  - use NuGet's V3 source by default
- update README.md

nits:
- `--source` -> `--package-source` due to conflict with a `dotnet` argument
- address Markdown lint warnings in README.md
- grab a couple of improvements from 'release/2.2'
  - never exit silently
  - remove `first` special case
- aspnet/AspNetCore-Internal#2474
@dougbu
Copy link
Contributor

dougbu commented May 7, 2019

Waiting for the other submodule update from 'release/2.1'

@dougbu dougbu self-assigned this May 7, 2019
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 7, 2019
@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@dotnet-maestro-bot dotnet-maestro-bot requested a review from a team as a code owner May 7, 2019 08:19
@JunTaoLuo
Copy link
Contributor

In that case I'll leave this open for now then.

@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@dougbu
Copy link
Contributor

dougbu commented May 8, 2019

Looking better but waiting for #10064 and then I'll do the needful

@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@dougbu
Copy link
Contributor

dougbu commented May 8, 2019

@JunTaoLuo any ideas about the following template error?

F:\workspace\_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.0\TestTemplates\AspNet.grpc.29b5ea\AspNet.grpc.29b5ea.csproj : error NU1102: Unable to find package Grpc.AspNetCore.Server with version (>= 0.1.21-dev201905010701)

@BrennanConroy
Copy link
Member

These PRs always look wrong, are they supposed to contain commits already in master?

@dougbu
Copy link
Contributor

dougbu commented May 8, 2019

are they supposed to contain commits already in master?

No, they shouldn't. I'll redo my local merge after grabbing the latest from 'master' and force-push the branch. But, first, I need to understand the gPRC errors.

@dougbu dougbu force-pushed the merge/release/2.2-to-master branch from 0d7f6ba to 82a68ea Compare May 8, 2019 19:22
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better 😺

@dougbu dougbu merged commit 16c01d5 into dotnet:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants