Disable request body data rate limits per HTTP/2 stream

[halter73]

Addresses #7635

[Tratcher]

The getter should return null if that's the only allowed value, or it should at least return null if already set to null. Throwing getters are no fun.

[halter73]

The thing is we generally are enforcing a rate limit for HTTP/2. It's just per connection, not per stream. So I don't think it makes sense to return null, but I also don't think it makes sense to return the entire connection's rate limit either.

[JamesNK]

I'd like to understand how we'll use this in gRPC.

I believe we only want to disable the rate limit on gRPC requests. We could be more specific and only disable the rate limit on client or duplex streaming request. Would that be done by setting this feature on the HttpContext with a null MinDataRate on only gRPC client/duplex streaming requests?

[halter73]

Would that be done by setting this feature on the HttpContext with a null MinDataRate on only gRPC client/duplex streaming requests?

Exactly. Something like https://github.com/aspnet/AspNetCore/pull/10355/files#diff-2d9b5c655816cc6e1ea41260d95cd33eR815

[JamesNK]

Ah, the IHttpMinRequestBodyDataRateFeature will always be set on a HTTP/2 request, and it is a matter of getting it and setting MinDataRate to null in the appropriate requests.

What happens if you have a HTTP/2 request and someone defines there own IHttpMinRequestBodyDataRateFeature implementation and has a non-null MinDataRate?

[halter73]

What happens if you have a HTTP/2 request and someone defines there own IHttpMinRequestBodyDataRateFeature implementation and has a non-null MinDataRate?

That's the prerogative of whoever defines their own IHttpMinRequestBodyDataRateFeature. I doubt a custom IHttpMinRequestBodyDataRateFeature would be able to do much with a non-null MinDataRate and an HTTP/2 request unless is measured the rate of the request body itself.

[halter73]

I expect most people who replace a IHttpMinRequestBodyDataRateFeature would be replacing it with a facade that would call the "real" MinDataRate setter which would throw a NotSupportedException given a non-null rate with HTTP/2.

[JamesNK]

Ok. I'm not super familiar with this space, just want to make sure it is thought about.