[Fixes #11183] Race condition in RouteBase.EnsureLoggers #11218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
javiercn
requested review from
pranavkm
and removed request for
analogrelay,
Tratcher and
jkotalik
javiercn
changed the title
rynowak
approved these changes
Jun 14, 2019
analogrelay
reviewed
Jun 14, 2019
analogrelay
added
the
area-mvc
|
Please add a comment. |
javiercn
force-pushed
the
javiercn/routing-1183
branch
from
bc8482c to
6150b66
Compare
Updated to use a lock, I wasn't sure how to accomplish that with LazyInitializer. Maybe I'm missing something. The alternative would have been to put each initialization inside LazyInitializer calls, which I imagine would have prevented reordering and have done the trick. |
pranavkm
approved these changes
Jun 14, 2019
javiercn
force-pushed
the
javiercn/routing-1183
branch
from
6150b66 to
e9bee6e
Compare
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorders lines to prevent race condition
#11183