Run signcheck if previous steps succeeded an try publishing build art… #11237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Jun 14, 2019
| @@ -126,7 +126,7 @@ jobs: | |||
| /bl:artifacts/log/build.signcheck.binlog | |||
| $(_BuildArgs) | |||
| displayName: Run sign check | |||
| condition: eq(variables['_SignType'], 'real') | |||
| condition: and(succeeded(), eq(variables['_SignType'], 'real')) | |||
There was a problem hiding this comment.
This should save about 1.5 minutes out of the 5 minutes grace period.
…ifacts before uploading test results
JunTaoLuo
force-pushed
the
johluo/shuffle-ci-steps
branch
from
ac03170 to
066034e
Compare
jkotalik
approved these changes
Jun 14, 2019
analogrelay
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help us debug what's going on when builds hang.