Skip to content

Fixes RequestHeader to allow working with KeyValuePair #12157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2019
Merged

Fixes RequestHeader to allow working with KeyValuePair #12157

merged 1 commit into from
Jul 14, 2019

Conversation

cjaliaga
Copy link
Member

  • Fixed ICollection.Add(KeyValuePair) and ICollection.Contains(KeyValuePair) as StringValues cannot be cast to object
  • Added test

Addresses #12114

@Tratcher
Copy link
Member

Thanks.

@Tratcher Tratcher merged commit 7d050e8 into dotnet:master Jul 14, 2019
@Tratcher Tratcher added this to the 3.0.0-preview8 milestone Jul 14, 2019
@cjaliaga cjaliaga deleted the request-header branch July 14, 2019 15:27
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
3.0.0-preview8
Development

Successfully merging this pull request may close these issues.
3 participants
@cjaliaga @Tratcher @amcasey