Harden StartCircuit #12825
Merged
Harden StartCircuit #12825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiercn - please take a look 😆 |
SteveSandersonMS
approved these changes
Aug 2, 2019
javiercn
reviewed
Aug 2, 2019
Fixes: #12057 Adds some upfront argument validation as well as error handling for circuit intialization failures.
Co-Authored-By: Brennan <[email protected]>
rynowak
force-pushed
the
rynowak/start-circuit
branch
from
02b16b7 to
c3a25a0
Compare
ghost
deleted the
@javiercn - if you still want to figure these things out, let's discuss next week. I'm interested to know if you have cool ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12057
Adds some upfront argument validation as well as error handling for
circuit intialization failures.