Skip to content

Fix Max Request Body Size test #12981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Aug 8, 2019

Failure here: https://dnceng.visualstudio.com/public/_build/results?buildId=262973&view=ms.vss-test-web.build-test-results-tab&runId=7075914&resultId=100906&paneView=attachments

Test was having logs get tangled between ANCM and Managed code. This disabled native logs for this test as we are trying to verify a warning message.

@BrennanConroy
Copy link
Member

Does this affect 3.0? If so the PR should target release/3.0

@jkotalik
Copy link
Contributor Author

jkotalik commented Aug 8, 2019

Yeah it would affect 3.0. I guess I'll merge it to that branch first.

@jkotalik jkotalik force-pushed the jkotalik/maxBodySizeFlakyFix branch from 6233a92 to 21ff3ac Compare August 8, 2019 17:32
@jkotalik jkotalik changed the base branch from master to release/3.0 August 8, 2019 17:32
@jkotalik jkotalik added area-servers tell-mode Indicates a PR which is being merged during tell-mode labels Aug 8, 2019
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@jkotalik jkotalik merged commit c6e1bcb into release/3.0 Aug 8, 2019
@ghost ghost deleted the jkotalik/maxBodySizeFlakyFix branch August 8, 2019 20:17
@analogrelay analogrelay added this to the 3.0.0-preview9 milestone Aug 9, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants