Make Partial on PageBase and PageModel work correctly #13013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
added
the
ask-mode
rynowak
reviewed
Aug 9, 2019
src/Mvc/Mvc.RazorPages/ref/Microsoft.AspNetCore.Mvc.RazorPages.netcoreapp3.0.cs
Show resolved
Hide resolved
|
Good to go? |
Eilon
added
the
area-mvc
pranavkm
force-pushed
the
prkrishn/partial
branch
from
ac1befc to
ab74f24
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10438
Description
The Partial method on PageBase and PageModel does not work correctly if a model (other than the PageModel instance is specified). This has been a bug since the feature was introduced in 2.2
Impact
Customers are unable to use this feature with arbitrary model types, a fairly common scenairo
Regression
No
Risk
Low. This feature never worked correctly so users have been working around it.