Mgbbs/hidden for checkbox render mode

[mgbbs]

Summary of the changes

• Added configurable CheckBox hidden input render mode

Addresses #12833

[dnfclas]

All CLA requirements met.

[mgbbs]

@Eilon is there an area with resources to help resolve build issues? I'm seeing an npm failure trying to resolve @mirosoft/signalr package, plus a few xunit tests are failing but I can't view the log details. All of the errors are unrelated to any of the changes in this pull request. I've tried some literal searches but nothing useful has turned up.

[Eilon]

Hi @mgbbs I actually don't work on this project anymore, I just help with labeling issues 😄

I'm tagging @aspnet/build and @mkArtakMSFT who should be able to help more with the build issues you're seeing (as well as reviewing the PR).

[pranavkm]

@mgbbs @BrennanConroy fixed the npm issue fairly recently. I think rebasing on master would help.
The test failures are a known issues and can be ignored (they're marked as flaky and will not fail the build).

[BrennanConroy]

The fix still needs to be merged to master which could be later today or tomorrow

[mgbbs]

Thanks guys, I assume it's commit e5485e9 so I'll watch for that to hit master then rebase.

[dougbu]

Suggest this should be in the same namespace as HtmlHelperOptions: Microsoft.AspNetCore.Mvc.ViewFeatures but defer to @pranavkm here

[mgbbs]

Thanks for the quick response @dougbu. I initially put it in the .Rendering namespace to follow suit with Html5DateRenderingMode and TagRenderMode, but will also defer to @pranavkm.

[pranavkm]

It seems OK to me. We'll do an API review in 5.0 and we can revisit this at that point.

[mgbbs]

@pranavkm this is rebased and updated per @dougbu's comments, and built successfully.

[dougbu]

Looks good to me. Over to you @pranavkm, especially on the namespace choice for the new enum

[mkArtakMSFT]

@dougbu please sign off, if you're done and happy with it. Let's get @pranavkm 's signoff too then to merge this.

[pranavkm]

Thanks for your PR @mgbbs

[pranavkm]

It seems OK to me. We'll do an API review in 5.0 and we can revisit this at that point.

[Tabgyn]

Is it available in .NET Core 3.1? How do I set this enumerator for all my application?

[mgbbs]

Is it available in .NET Core 3.1? How do I set this enumerator for all my application?

@Tabgyn looks like it'll be available in .NET 5. It will be configured like so:

            services.Configure<MvcViewOptions>(options =>
            {
                options.HtmlHelperOptions.CheckBoxHiddenInputRenderMode = CheckBoxHiddenInputRenderMode.Inline;
            });