Skip to content

ClientCollection builder methods returns with client #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

ClientCollection builder methods returns with client #13437

merged 1 commit into from
Jul 1, 2020

Conversation

tibitoth
Copy link
Contributor

@tibitoth tibitoth commented Aug 25, 2019

Summary of the changes

  • ClientCollection AddNativeApp, AddIdentityServerSPA and AddSPA methods return with the client

Addresses #13435

@Pilchie Pilchie added the area-identity Includes: Identity and providers label Aug 26, 2019
@HaoK
Copy link
Member

HaoK commented Jun 29, 2020

Closing and reopning to trigger new test runs

@HaoK HaoK closed this Jun 29, 2020
@HaoK HaoK reopened this Jun 29, 2020
@tibitoth
Copy link
Contributor Author

Closing and reopning to trigger new test runs

I think I need to rebase/retarget these changes, am I right?

@HaoK
Copy link
Member

HaoK commented Jun 30, 2020

master is fine, you might need to rebase against master though

@tibitoth
Copy link
Contributor Author

tibitoth commented Jul 1, 2020

@HaoK done and PR checks are fine now

@HaoK
Copy link
Member

HaoK commented Jul 1, 2020

Cool thanks @tibitoth

@HaoK HaoK merged commit 1688b5a into dotnet:master Jul 1, 2020
@tibitoth tibitoth deleted the fix-13435 branch July 1, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants