Skip to content

Added .env files to the react project templates in order to run the CRA server independently. #13525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2019

Conversation

dannyBies
Copy link
Contributor

Added .env files to the react project templates in order to run the CRA server independently.

PR based on #12435

Fixes #7286

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 29, 2019
@mkArtakMSFT mkArtakMSFT requested review from ryanbrandenburg and danroth27 and removed request for analogrelay and Tratcher August 29, 2019 22:48
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dannyBies.
@danroth27 given this is change on the template level, would be great to have your signoff on this too.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@mkArtakMSFT mkArtakMSFT merged commit 026b9df into dotnet:master Aug 30, 2019
@mkArtakMSFT
Copy link
Contributor

Thanks for the PR, @dannyBies.

dougbu added a commit to dotnet-maestro-bot/AspNetCore that referenced this pull request Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet new react requires .env
5 participants