Skip to content

[SignalR] Remove a few minor allocations #13872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

[SignalR] Remove a few minor allocations #13872

merged 1 commit into from
Sep 11, 2019

Conversation

BrennanConroy
Copy link
Member

CreateLinkedTokenSource(x, default) gets around the param object[] allocation.

Passing object state to functions removes the variable capture allocs.

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Sep 10, 2019
@BrennanConroy BrennanConroy added this to the 5.0.0-preview1 milestone Sep 10, 2019
@mikaelm12
Copy link
Contributor

Numbers? 😄

@davidfowl
Copy link
Member

What @mikaelm12 said

@BrennanConroy
Copy link
Member Author

Before for Closure:
image

After for Closure:
image

Before for CTS:
image

After for CTS:
image

@BrennanConroy BrennanConroy merged commit 9557630 into master Sep 11, 2019
@BrennanConroy BrennanConroy deleted the brecon/alloc branch September 11, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @mikaelm12 @davidfowl