Add support for negotiateVersion query string parameter #13880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelm12
requested review from
analogrelay,
BrennanConroy and
halter73
as code owners
halter73
reviewed
Sep 17, 2019
src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HubConnection.java
Outdated
Show resolved
Hide resolved
halter73
reviewed
Sep 17, 2019
src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HubConnection.java
Outdated
Show resolved
Hide resolved
src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java
Outdated
Show resolved
Hide resolved
src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java
Outdated
Show resolved
Hide resolved
src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java
Outdated
Show resolved
Hide resolved
|
🆙 📅 |
halter73
reviewed
Sep 18, 2019
src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HubConnection.java
Outdated
Show resolved
Hide resolved
halter73
reviewed
Sep 18, 2019
| @@ -521,6 +525,7 @@ private void stopConnection(String errorMessage) { | |||
| handshakeResponseSubject.onComplete(); | |||
| redirectAccessTokenProvider = null; | |||
| connectionId = null; | |||
| connectionToken = null; | |||
There was a problem hiding this comment.
Are we trying to follow any convention related to using or not using this. to access fields?
There was a problem hiding this comment.
We should, but not currently. It's just random right now.
…ignalr/HubConnection.java Co-Authored-By: Stephen Halter <[email protected]>
halter73
reviewed
Sep 18, 2019
src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HubConnectionTest.java
Show resolved
Hide resolved
halter73
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on the
negotiateVersionchanges from #13389 for the Java client.I'll probably just leave this as a draft until the connectionToken change #13773 goes and make the necessary changes in this branch as well.