Skip to content

Improve performance for QueuePolicy in ConcurrencyLimiter #13947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2019
Merged

Improve performance for QueuePolicy in ConcurrencyLimiter #13947

merged 3 commits into from
Nov 1, 2019

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Sep 13, 2019

  • Store MaxTotalRequest instead of MaxConcurrentRequests and RequestQueueLimit separately and calculating the sum in every request.
  • Make TryEnterAsync non async for the performance for when total request has reached to maximum

@Kahbazi Kahbazi force-pushed the kahbazi/concurrenyMiddlewarePerf branch from 6fe4566 to 20490e9 Compare September 13, 2019 11:18
@Kahbazi Kahbazi changed the title Improve performance Improve performance for QueuePolicy in ConcurrencyLimiter Sep 13, 2019
gfoidl
gfoidl reviewed Sep 13, 2019
View reviewed changes
jkotalik
jkotalik reviewed Sep 19, 2019
View reviewed changes
@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Sep 19, 2019
jkotalik
jkotalik approved these changes Sep 30, 2019
View reviewed changes
@analogrelay
Copy link
Contributor

Seems we're probably ready to take this. I'll respin the builds to get us to green :).

@analogrelay
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jkotalik
Copy link
Contributor

/azp run

@jkotalik jkotalik self-assigned this Oct 31, 2019
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@halter73
Copy link
Member

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=409962

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2726

@halter73
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@halter73 halter73 mentioned this pull request Oct 31, 2019
Merged
@halter73 halter73 merged commit 61179f3 into dotnet:master Nov 1, 2019
@halter73
Copy link
Member

halter73 commented Nov 1, 2019

Thanks again @Kahbazi

@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfoidl gfoidl gfoidl left review comments

@jkotalik jkotalik jkotalik approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@halter73 halter73

@jkotalik jkotalik

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
8 participants
@Kahbazi @analogrelay @jkotalik @halter73 @aspnet-hello @gfoidl @Pilchie @amcasey