Make IntegrationTesting not depend on M.A.Hosting.Abstractions #14112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14085
The Microsoft.AspNetCore.Server.IntegrationTesting package depends on Microsoft.AspNetCore.Hosting.Abstractions. If someone were referencing the integration testing package outside of AspNetCore, it would be broken as there is a missing dependency. This is exactly what the benchmarks repo was doing to pull in ANCM. It takes a dependency on this package to pull in ANCM into the right location, sxs with the app: https://github.com/aspnet/Benchmarks/blob/master/src/Benchmarks/Benchmarks.csproj#L70. So if we can remove the dependency on M.A.Hosting.Abstractions, we can now use this package outside of the repo.
This package only used M.A.Hosting.Abstractions for a single, one-line extension method. I decided to remove it and create a helper class instead.
Few things:
@sebastienros I'll need some help verifying this change on Benchmarks.
Also, this change should be backported to 3.x