Skip to content

[TS] Add support for negotiateVersion and connectionToken #14157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2019

Conversation

BrennanConroy
Copy link
Member

Follow up to #13389 for the TS client

Couple things I changed from the other clients implementations that I'll fix for them in a different PR:

  • negotiateVersion is not included after negotiation occurs
  • negotiateVersion is not added multiple times when redirecting (otherwise this would break the service scenario)
  • connectionToken is not stored anywhere

Side-note: Fixed a bug where the connectionId property wasn't updated when fallback occurs.

@BrennanConroy BrennanConroy added area-signalr Includes: SignalR clients and servers 3.1-candidate labels Sep 19, 2019
@BrennanConroy BrennanConroy added this to the 5.0.0-preview1 milestone Sep 19, 2019
@BrennanConroy BrennanConroy merged commit a2d217c into master Sep 25, 2019
@BrennanConroy BrennanConroy deleted the brecon/tsSplit branch September 25, 2019 19:38
@xepozz
Copy link

xepozz commented Aug 11, 2023

@BrennanConroy I see that one of problems was:

connectionToken is not stored anywhere

So is it stored anywhere after this PR? Is it accessible?
I've researched almost whole library, but didn't find the way to access it. I think the way could be done with adding similar to

get connectionId(): string | null {
return this.connection ? (this.connection.connectionId || null) : null;
}
method, but I don't know anything about the library architecture.

@ghost
Copy link

ghost commented Aug 11, 2023

Hi @xepozz. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants