Skip to content

Fixes in DownloadPersonalData #14203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2019
Merged

Fixes in DownloadPersonalData #14203

merged 4 commits into from
Oct 22, 2019

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Sep 20, 2019

Fixes #14178 #5800

@HaoK HaoK requested a review from javiercn September 20, 2019 20:24
@Honjoy
Copy link

Honjoy commented Sep 21, 2019

maybe change Encoding.UTF8.GetBytes(JsonSerializer.Serialize(personalData)) => JsonSerializer.SerializeToUtf8Bytes(personalData) is better.

@Pilchie Pilchie added the area-identity Includes: Identity and providers label Sep 23, 2019
@HaoK
Copy link
Member Author

HaoK commented Oct 3, 2019

Thanks for the suggestion @Honjoy

@pranavkm pranavkm added this to the 3.1.0-preview2 milestone Oct 10, 2019
pranavkm
pranavkm suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one: https://github.com/aspnet/AspNetCore/blob/release/3.1/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj#L39

@HaoK HaoK modified the milestones: 3.1.0-preview2, 5.0.0-preview1 Oct 11, 2019
@HaoK HaoK changed the base branch from release/3.1 to master October 17, 2019 20:25
@HaoK HaoK merged commit 8a4b839 into master Oct 22, 2019
@HaoK HaoK deleted the identity-json branch October 22, 2019 19:56
@HaoK HaoK mentioned this pull request Oct 22, 2019
Closed
@vanillajonathan
Copy link
Contributor

Should it use FileContentResult or JsonResult?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm requested changes

@javiercn javiercn javiercn left review comments

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.

Identity -> DownloadPersonalData.cshtml.cs Remove dependencies on Newtonsoft.Json
6 participants
@HaoK @Honjoy @vanillajonathan @pranavkm @javiercn @Pilchie