[Templates] Separate F# from C# tests, unskip tests, include reliability improvements #14261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
requested review from
ryanbrandenburg and
SteveSandersonMS
as code owners
ryanbrandenburg
approved these changes
Sep 23, 2019
| }, logger: NullLogger.Instance); | ||
|
|
||
| Assert.True(IsSuccessStatusCode(result), $"{anchor.Href} is a broken link!"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private async Task<T> RequestWithRetries<T>(Func<HttpClient, Task<T>> requester, HttpClient client, int retries = 3, TimeSpan initialDelay = default) |
There was a problem hiding this comment.
I could have sworn we already had a function like this but I can't find it.
There was a problem hiding this comment.
I was doing it wrong in another PR so i ended up not merging it.
javiercn
force-pushed
the
javiercn/separate-fsharp-tests
branch
from
ece1c31 to
c7dc422
Compare
javiercn
added
the
tell-mode
…ity improvements. * Separates F# from C# tests. These tests have very different runtime characteristics and should not be bundled together as the same test scenario. For example, we want to quickly separate F# specific issues from C# specific ones. * Unskipping all skipped tests as the issue tracking their flakyness was closed. * Adding reliability improvements to network requests. * Adds retries.
javiercn
removed
the
tell-mode
javiercn
force-pushed
the
javiercn/separate-fsharp-tests
branch
from
c7dc422 to
505d68b
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
characteristics and should not be bundled together as the same test
scenario. For example, we want to quickly separate F# specific issues
from C# specific ones.
was closed.