-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Helix] Use standard win10 helix queues #14263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Tratcher can you help me isolate what might be related to using a normal windows 10 helix machine instead of the custom win10 helix queue we are currently using? It looks like these are the tests that might be running into issues:
which affects: At first glace there only appears to be one test that fails if we stop using our custom win10 queue for our runs... @jkotalik are you aware of any other iis tests that require any specific configuration still? |
The PlatformNotSupportedException is weird. @halter73 ? |
It works on |
Or I guess |
What machines are the UnixDomainSocketsTests failing on? Unix domain socket support was added in Windows 10 Build 1803, but our skip condition only skips Windows 8.1 and below. Is there a way to skip based on build number? |
@Tratcher @halter73 are you guys ok if we just skip these unix socket tests on helix for now, since will be covered in the existing windows tests if I undo the change to the OSSkip and just disable these few tests entirely on helix? I'll file an issue tracking tracking that they are skipped on helix since it looks like we can run on the normal windows10 queues that everyone else uses then |
That's fine. Assign it to both of us. We'll need to update the OS skip conditions anyways to support various Win10 versions. |
Got a clean helix test run on the normal queues, removing the enable by default logic now that we don't need the special queues and marking as ready for review (@aspnet/build) |
Switching to the win10 queues that everyone else uses should result in a lot less waiting as the pools will be scaled and hot more often, our custom queues would take up to 45 minutes to setup a new machine from a cold queue