Skip to content

Avoid null refs in BlazorIgntior when Disposed #14341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2019
Merged

Avoid null refs in BlazorIgntior when Disposed #14341

merged 3 commits into from
Sep 25, 2019

Conversation

pranavkm
Copy link
Contributor

Fixes #14257

  • Minor cleanup
  • Update instructions to say chrome needs to be installed for Selenium

@pranavkm pranavkm requested a review from javiercn September 23, 2019 21:53
javiercn
javiercn reviewed Sep 23, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to throw ObjectDisposedException if used after disposed? Or is this for calls that might come from the server?

javiercn
javiercn approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to throw ObjectDisposedException if used after disposed? Or is this for calls that might come from the server?

@pranavkm
Copy link
Contributor Author

Not sure I follow. When would we throw the ObjectDisposedException?

@javiercn
Copy link
Member

When would we throw the ObjectDisposedException?

When checking for Disposed?

@javiercn
Copy link
Member

When would we throw the ObjectDisposedException?

When checking for Disposed?

Discussed offline. Pranav is doing the right thing.

rynowak
rynowak reviewed Sep 24, 2019
View reviewed changes
src/Shared/E2ETesting/BrowserFixture.cs
@@ -108,7 +108,7 @@ private async Task<(IWebDriver browser, ILogs log)> CreateBrowserAsync(string co
var instance = await SeleniumStandaloneServer.GetInstanceAsync(output);

var attempt = 0;
var maxAttempts = 3;
const int maxAttempts = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we doing this now?

rynowak
rynowak reviewed Sep 24, 2019
View reviewed changes
src/Components/Ignitor/src/BlazorClient.cs Outdated
@@ -56,7 +56,7 @@ public BlazorClient()

private CancellableOperation<CapturedAttachComponentCall> NextAttachComponentReceived { get; set; }

private CancellableOperation<CapturedRenderBatch> NextBatchReceived { get; set; }
internal CancellableOperation<CapturedRenderBatch> NextBatchReceived { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this internal?

pranavkm
pranavkm commented Sep 24, 2019
View reviewed changes
SteveSandersonMS
SteveSandersonMS reviewed Sep 24, 2019
View reviewed changes
src/Shared/E2ETesting/BrowserFixture.cs
} while (attempt < maxAttempts);

// We will never get here. Keeping the compiler happy.
throw new InvalidOperationException("Couldn't create a Selenium remote driver client. The server is unresponsive");
throw new InvalidOperationException("Couldn't create a Selenium remote driver client. The server is irresponsive");
Copy link
Member

@SteveSandersonMS SteveSandersonMS Sep 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new InvalidOperationException("Couldn't create a Selenium remote driver client. The server is irresponsive");
throw new InvalidOperationException("Couldn't create a Selenium remote driver client. The server is anti-responsive");

(Joking, but wouldn't a better message be something like "This line of code should not be reachable", given the comment above?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely orthogonal comment, I've seen selenium timeout in some tests, I'm wondering if we have instances where it becomes irresponsible. And if we should change the code that initializes selenium (in the future) to do this check on a per-test basis and switch the server (start a new one) if it detects the current one is not being responsive.

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Sep 24, 2019
@pranavkm
Copy link
Contributor Author

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=365210&view=ms.vss-test-web.build-test-results-tab&runId=11048896&resultId=127258&paneView=debug

@pranavkm pranavkm merged commit 1937c80 into release/3.1 Sep 25, 2019
@pranavkm pranavkm deleted the prkrishn/fix-null-ref branch September 25, 2019 22:01
@pranavkm pranavkm added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@rynowak rynowak rynowak left review comments

@javiercn javiercn javiercn approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pranavkm @javiercn @SteveSandersonMS @rynowak @Pilchie