Skip to content

[release/3.0] Update gRPC package version to 2.23.2 #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

[release/3.0] Update gRPC package version to 2.23.2 #14352

merged 1 commit into from
Oct 2, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 24, 2019 •
edited
Loading

Fixes #14348

Description

Update Grpc.AspNetCore reference in gRPC template to 2.23.2.

Customer impact

Template currently references 2.23.1. This package is impacted by the NuGet deterministic issue, which could result in some gRPC runtime files not being deployed.

Regression

No

Risk

Low

@JamesNK JamesNK added Servicing-consider Shiproom approval is required for the issue area-grpc Includes: GRPC wire-up, templates labels Sep 24, 2019
@JamesNK JamesNK added this to the 3.0.x milestone Sep 24, 2019
@JamesNK JamesNK requested a review from dougbu as a code owner September 24, 2019 03:16
dougbu
dougbu approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM if QB approved

@analogrelay analogrelay changed the title [3.0.x] Update gRPC package version to 2.23.2 [release/3.0] Update gRPC package version to 2.23.2 Sep 26, 2019
@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 26, 2019
@Pilchie
Copy link
Member

Pilchie commented Sep 26, 2019

@JamesNK This is approved for 3.0.1. Go ahead and merge when tests are ok.

@dougbu
Copy link
Contributor

dougbu commented Sep 26, 2019

@JamesNK please do not merge until #14404 is in

@JamesNK JamesNK force-pushed the jamesnk/3.0-grpc-version branch from bd10bfd to e1d21bc Compare October 2, 2019 02:29
@JamesNK
Copy link
Member Author

JamesNK commented Oct 2, 2019

Merge button is disable. I'm guessing I don't have permission.

Merge pls 🙏

Also, will this make it into 3.1?

@Pilchie Pilchie changed the base branch from release/3.0 to release/3.1-preview1 October 2, 2019 15:54
@Pilchie Pilchie changed the base branch from release/3.1-preview1 to release/3.1 October 2, 2019 15:54
@Pilchie
Copy link
Member

Pilchie commented Oct 2, 2019

I broke it :( I was going to retarget the base to release/3.1-preview1 so that it could be in Preview 1, but it picked up more commits, that stayed even when I retargeted back to release/3.1.

Can someone fix the branch and re-target to release/3.1-preview1 so we can get it in today?

@dougbu dougbu force-pushed the jamesnk/3.0-grpc-version branch from e1d21bc to 2f58fcd Compare October 2, 2019 16:47
@dougbu dougbu changed the base branch from release/3.1 to release/3.1-preview1 October 2, 2019 16:48
@dougbu
Copy link
Contributor

dougbu commented Oct 2, 2019

@Pilchie done

All other "reviewers" sorry for the spam. As usual GitHub went rogue between pushing the rebased branch and resetting the PR's target.

@Pilchie
Copy link
Member

Pilchie commented Oct 2, 2019

Thanks @dougbu! Let's merge this once green.

@Pilchie Pilchie merged commit 6dc49b4 into release/3.1-preview1 Oct 2, 2019
@Pilchie Pilchie deleted the jamesnk/3.0-grpc-version branch October 2, 2019 20:02
@Pilchie
Copy link
Member

Pilchie commented Oct 2, 2019

Wait - we put this in 3.1-preview1, but we wanted to put it in 3.0.x :(

@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

My bad. Do you want me to push a revert commit directly into 'release/3.1-preview1` and then rebase @JamesNK's branch (which I still have locally)?

@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

Or, do we want it in both branches?

@JamesNK
Copy link
Member Author

JamesNK commented Oct 3, 2019 •
edited
Loading

Both branches. This PR doesn't need to be revered.

@Pilchie Pilchie modified the milestones: 3.0.x, 3.1.0-preview1 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilchie Pilchie Pilchie approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-grpc Includes: GRPC wire-up, templates Servicing-approved Shiproom has approved the issue Servicing-consider Shiproom approval is required for the issue
Projects
None yet
Milestone
3.1.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesNK @Pilchie @dougbu @JunTaoLuo