IISHttpContext.FeatureCollection.Protocol recognizes HTTP/2 #14412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
gfoidl
commented
Sep 25, 2019
src/Servers/IIS/IIS/src/Core/IISHttpContext.FeatureCollection.cs
Outdated
Show resolved
Hide resolved
gfoidl
commented
Sep 25, 2019
Tratcher
reviewed
Sep 25, 2019
analogrelay
reviewed
Sep 25, 2019
| { | ||
| internal static class Extensions | ||
| { | ||
| public static string GetHttpProtocolVersion(this Version version) => version switch |
There was a problem hiding this comment.
Ooooh, fancy new C# 8.0 features 😜
There was a problem hiding this comment.
🎯 it's a better showcase than the one from the docs 😃
Tratcher
approved these changes
Sep 25, 2019
|
Thanks |
|
Unit tests that both Kestrel and IIS has the correct value? |
|
When I should add tests, please give me some pointers where to put them (aside from the question in the description above). For me this are too many server projects* -- so maybe someone else can add these tests... * in the positive sense, but I'm not too familiar with them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #14139
A difficult change 😉
Could not find any explicit tests for this -- aren't there any?