Skip to content

Update templates for 3.1 #14490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes #14486.

@mkArtakMSFT
Copy link
Contributor

@aspnet/build folks,I assume the <TargetFramework> in the change in .csproj files will happen as part of rebranding work? Currently it's defined as below:

<TargetFramework>${DefaultNetCoreTargetFramework}</TargetFramework>

Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly handling this, @ryanbrandenburg.
Let's get this merged after getting confirmation from the Build folks first.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 27, 2019

I assume the in the change in .csproj files will happen as part of rebranding work?

Yes, it should just get the right value from root dir.build.props:
https://github.com/aspnet/AspNetCore/blob/release/3.1/Directory.Build.props#L55

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 27, 2019
@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2019

it should just get the right value from root dir.build.props

And, the value is correct in every branch 😺

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanbrandenburg please also update 'master' to use 5.0 identities and perhaps a still-higher precedence

@ryanbrandenburg
Copy link
Contributor Author

Closing in favor of #14637 which uses the new branch.

@dougbu dougbu deleted the rybrande/Templating/Update branch May 18, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants