Fix null reference exception for Streaming null object (#14004) #14515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
area-signalr
BrennanConroy
requested review from
analogrelay,
halter73 and
mikaelm12
as code owners
|
I presume our reasoning for only back-porting to 3.1 is that it's the LTS? Both 2.2 and 3.0 are "Current" releases, so we don't feel a need to back-port there because of the limited lifetime of those releases? |
That was my reasoning |
Pilchie
approved these changes
Sep 27, 2019
|
Approved. |
BrennanConroy
changed the base branch from
release/3.1
to
release/3.1-preview1
halter73
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 2.2 we added Server-to-client streaming as well as the ability to accept a CancellationToken in your streaming hub methods so you can observe when the stream has been canceled by the client.
There is a bug where if the user provides null as one of the values to an argument to the hub method then we will nullref and return an error to the client.
Customer Impact
This was a customer reported issue.
If someone passes a null object (which is a valid scenario) to a streaming hub method that accepts a CancellationToken they will get a null ref on the server and the method will not be invoked.
Regression?
No, this has been a bug since the feature was introduced in 2.2.
Risk
Low, added test coverage to prevent this kind of issue in the future
@Pilchie I believe we need your approval for bug fixes