Skip to content

Make UseStatusCodePagesWithReExecute clear Endpoints #14531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Sep 27, 2019

#13715 There was a regression when switching to Endpoint based routing. When the status code component tries to re-execute the pipeline there is some state that needs to be cleared first such as the endpoint, otherwise the request will be routed to the old endpoint again.

Normally a middleware would do it's own cleanup (e.g. routing), but that significantly impacted the perf in the case of routing.

In 3.0 @NTaylorMullen Fixed this in UseExceptionHandlerWithReExecute but we missed UseStatusCodePagesWithReExecute.
1f0641f#diff-abb2b51ad2d2d988debc78909b2674d9

FYI: I split the test files for exception handler and status code handler.

@Tratcher Tratcher added this to the 3.1.0-preview1 milestone Sep 27, 2019
@Tratcher Tratcher self-assigned this Sep 27, 2019
@analogrelay
Copy link
Contributor

Will need @Pilchie approval to take a bug fix in 3.1

@Tratcher Tratcher force-pushed the tratcher/3.1/reexecute branch from 435bc1e to 37b4be6 Compare October 1, 2019 15:23
@Tratcher Tratcher changed the base branch from release/3.1 to release/3.1-preview1 October 1, 2019 15:24
@Tratcher
Copy link
Member Author

Tratcher commented Oct 1, 2019

@Pilchie @anurse this is ready to merge.

@analogrelay
Copy link
Contributor

Seems good to me given that we did it for UseExceptionHandlerWithReExecute. I endorse this for 3.1

@Pilchie
Copy link
Member

Pilchie commented Oct 1, 2019

Agreed. Approved for 3.1

@analogrelay analogrelay merged commit 12cba32 into release/3.1-preview1 Oct 1, 2019
@analogrelay analogrelay deleted the tratcher/3.1/reexecute branch October 1, 2019 23:05
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants