-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update package baseline #14535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package baseline #14535
Conversation
Interesting:
Implies that EDIT - whoops, never mind, I missed updating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once things work, go for it
Please file the follow-up bug about improving the baseline generator so that we can include the shared framework in the baseline
<TarCommand Condition="'$(OS)' == 'Windows_NT'">C:\Windows\System32\tar.exe</TarCommand> | ||
<TarCommand Condition="'$(OS)' == 'Windows_NT' and !Exists($(TarCommand))">'C:\Program Files\Git\usr\bin\tar.exe'</TarCommand> | ||
<TarCommand Condition="'$(OS)' == 'Windows_NT' and !Exists($(TarCommand))">'C:\Program Files (x86)\Git\usr\bin\tar.exe'</TarCommand> | ||
<TarCommand Condition="'$(OS)' != 'Windows_NT'">tar</TarCommand> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<TarCommand Condition="'$(OS)' != 'Windows_NT'">tar</TarCommand> | |
<TarCommand>tar</TarCommand> | |
<TarCommand Condition="'$(OS)' == 'Windows_NT'">C:\Windows\System32\tar.exe</TarCommand> | |
<TarCommand Condition="'$(OS)' == 'Windows_NT' and !Exists('$(TarCommand)')">C:\Program Files\Git\usr\bin\tar.exe</TarCommand> | |
<TarCommand Condition="'$(OS)' == 'Windows_NT' and !Exists('$(TarCommand)')">C:\Program Files (x86)\Git\usr\bin\tar.exe</TarCommand> |
Single quotes aren't going to work w/ cmd
but are useful when calling Exists(...)
. And, this simplifies things a bit.
@@ -175,7 +183,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant | |||
Overwrite="true" /> | |||
<!-- Requires Windows 10 version 1803 or newer --> | |||
<Exec | |||
Command="tar -czf $(TarArchiveOutputPath) ." | |||
Command="$(TarCommand) -czf $(TarArchiveOutputPath) ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command="$(TarCommand) -czf $(TarArchiveOutputPath) ." | |
Command=""$(TarCommand)" -czf $(TarArchiveOutputPath) ." |
Quotes are also great in <Exec />
😺
<TarCommand Condition="'$(OS)' == 'Windows_NT'">C:\Windows\System32\tar.exe</TarCommand> | ||
<TarCommand Condition="'$(OS)' == 'Windows_NT' and !Exists($(TarCommand))">'C:\Program Files\Git\usr\bin\tar.exe'</TarCommand> | ||
<TarCommand Condition="'$(OS)' == 'Windows_NT' and !Exists($(TarCommand))">'C:\Program Files (x86)\Git\usr\bin\tar.exe'</TarCommand> | ||
<TarCommand Condition="'$(OS)' != 'Windows_NT'">tar</TarCommand> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same deal as the other project
Not sure what I hit to close this. Entirely unintended. |
Previous build got
BTW one of @alexperovich's theories was that the agents were inconsistent. He found |
FYI I stole a variant of your |
Contributes to #12702
The update to
Baseline.xml
is manual - I added all packages that AspNetCore shipped in 3.0 GA, but picked only 1 version of the shared framework package (Microsoft.AspNetCore.App.runtime-winx64
). The update toBasline.Designer.props
was done by running the BaselineGenerator project.Replaces #14437