Skip to content

Update branding to 3.1.0-preview2 #14563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Sep 29, 2019

No description provided.

@dougbu dougbu added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Sep 29, 2019
@dougbu dougbu requested a review from a team September 29, 2019 19:00
@dougbu
Copy link
Contributor Author

dougbu commented Sep 29, 2019

Blocked just 'til we branch

@dougbu dougbu added the blocked The work on this issue is blocked due to some dependency label Sep 29, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Sep 30, 2019

🆙📅 to include dotnet/core-eng#7970 workaround

- work around dotnet/core-eng#7970
- install Git in repo if Tar can't be found in usual locations
- use found or installed Tar in Microsoft.AspNetCore.App.Ref project
  - copy into repo from wherever it's found
- add lots of `Write-Host` debugging

nit: clean up / comment on VS Code warnings about build.ps1
@dougbu dougbu force-pushed the dougbu/preview2-branding branch from 9316182 to f6eab78 Compare September 30, 2019 23:06
@dougbu
Copy link
Contributor Author

dougbu commented Oct 1, 2019

Success modulo a missing New-Item -ItemType Directory .\.tools\ -ErrorAction SilentlyContinue and a macOS agent disappearing ❕❕

@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Oct 1, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Oct 1, 2019

/bump reviewers (no longer blocked)

@dougbu dougbu merged commit a81b675 into release/3.1 Oct 1, 2019
@ghost ghost deleted the dougbu/preview2-branding branch October 1, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants