Skip to content

Handle exceptions thrown by PEReader #14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2019
Merged

Handle exceptions thrown by PEReader #14612

merged 3 commits into from
Oct 8, 2019

Conversation

khellang
Copy link
Member

@khellang khellang commented Oct 1, 2019

If the PEReader fails to read the debug directory from the assembly, the GetMetadataReader will now return null and short-circuit in PopulateStackFrame.

Fixes #14609

halter73
halter73 reviewed Oct 1, 2019
View reviewed changes
@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Oct 1, 2019
@khellang khellang force-pushed the badimageformatexception-fix branch from e77c0b9 to 499e7bb Compare October 3, 2019 08:56
@khellang khellang requested a review from analogrelay as a code owner October 3, 2019 08:56
davidfowl
davidfowl reviewed Oct 3, 2019
View reviewed changes
davidfowl
davidfowl reviewed Oct 3, 2019
View reviewed changes
davidfowl
davidfowl reviewed Oct 3, 2019
View reviewed changes
@khellang khellang force-pushed the badimageformatexception-fix branch from 499e7bb to 61e615b Compare October 3, 2019 08:59
khellang
khellang commented Oct 3, 2019
View reviewed changes
@khellang khellang force-pushed the badimageformatexception-fix branch from 61e615b to f063757 Compare October 3, 2019 09:01
khellang
khellang commented Oct 3, 2019
View reviewed changes
@khellang khellang requested review from davidfowl and halter73 October 3, 2019 09:04
@khellang khellang force-pushed the badimageformatexception-fix branch from 87a714b to 938ef05 Compare October 8, 2019 07:42
@khellang
Copy link
Member Author

khellang commented Oct 8, 2019

Looks like the CI is really flaky lately... 😞

@davidfowl davidfowl merged commit d4a2fa1 into dotnet:master Oct 8, 2019
@khellang khellang deleted the badimageformatexception-fix branch October 8, 2019 17:45
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@jkotalik jkotalik Awaiting requested review from jkotalik

@pranavkm pranavkm Awaiting requested review from pranavkm

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.

PortablePdbReader/ExceptionDetailsProvider may throw an exception which causes problems in callers like DeveloperExceptionPageMiddleware
7 participants
@khellang @halter73 @davidfowl @Tratcher @analogrelay @Pilchie @amcasey