Port https://github.com/aspnet/AspNetCore/pull/12879 to 3.1 #14638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
reviewed
Oct 1, 2019
| using var testResult = await ProcessEx.RunViaShellAsync(Output, clientAppSubdirPath, "npm run test"); | ||
| Assert.True(0 == testResult.ExitCode, ErrorMessages.GetFailedProcessMessage("npm run test", Project, testResult)); | ||
| } | ||
| var testcommand = "npm run test" + template == "angular" ? "-- --watch=false" : ""; |
There was a problem hiding this comment.
I don't know why this conditional argument is needed. Can you add a comment?
| @@ -104,14 +104,14 @@ public static ProcessEx Run(ITestOutputHelper output, string workingDirectory, s | |||
| return new ProcessEx(output, proc); | |||
| } | |||
|
|
|||
| public static async Task<ProcessEx> RunViaShellAsync(ITestOutputHelper output, string workingDirectory, string commandAndArgs) | |||
| public static ProcessEx RunViaShell(ITestOutputHelper output, string workingDirectory, string commandAndArgs) | |||
There was a problem hiding this comment.
await result.Exited was the last async thing in this function, without it we get that annoying warning/error about an async with nothing awaited. Unfortunately I wasn't able to find/manufacture an overload to wait for result to complete that was both async and did a timeout.
ajaybhargavb
approved these changes
Oct 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13925.