Skip to content

Merge Pass SubProtocols from TestHost WebSocketClient (#14666) #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from Oct 3, 2019
Merged

Merge Pass SubProtocols from TestHost WebSocketClient (#14666) #14667

merged 4 commits into from Oct 3, 2019

Conversation

smudge202
Copy link
Contributor

  • Use SubProtocols property on TestHost's WebSocketClient to populate Sec-WebSocket-Protocol header

Addresses #14666

@dnfclas
Copy link

dnfclas commented Oct 2, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

Tratcher
Tratcher reviewed Oct 2, 2019
View reviewed changes
@Tratcher Tratcher self-assigned this Oct 2, 2019
@Eilon Eilon added the feature-websockets Includes: WebSockets label Oct 2, 2019
Tratcher
Tratcher approved these changes Oct 2, 2019
View reviewed changes
@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Oct 2, 2019
@Tratcher Tratcher removed the feature-websockets Includes: WebSockets label Oct 2, 2019
@Tratcher
Copy link
Member

Tratcher commented Oct 2, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=373927&view=ms.vss-test-web.build-test-results-tab&runId=11439092&paneView=debug&resultId=102685

@Tratcher
Copy link
Member

Tratcher commented Oct 2, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=373928&view=ms.vss-test-web.build-test-results-tab&runId=11437752&resultId=117528&paneView=debug

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/3128
https://github.com/aspnet/AspNetCore-Internal/issues/3173
https://github.com/aspnet/AspNetCore-Internal/issues/3172

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2358
https://github.com/aspnet/AspNetCore-Internal/issues/2617

@Tratcher
Copy link
Member

Tratcher commented Oct 3, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=375181

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/3128
https://github.com/aspnet/AspNetCore-Internal/issues/2483

@Tratcher Tratcher merged commit af8d35d into dotnet:master Oct 3, 2019
@Tratcher
Copy link
Member

Tratcher commented Oct 3, 2019

Thanks

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
8 participants
@smudge202 @dnfclas @Tratcher @aspnet-hello @BrennanConroy @analogrelay @Eilon @amcasey