-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[automated] Merge branch 'release/2.2' => 'release/3.0' #14714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated] Merge branch 'release/2.2' => 'release/3.0' #14714
Conversation
* Re-implement SameSite for 2019 dotnet#12125 * Rename compat flag * Use Microsoft.AspNetCore.SuppressSameSiteNone compat key * Backport CookiePolicy quirk and sample * Patch config
* Re-implement SameSite for 2019 dotnet#12125 * Rename compat flag * References * Use Microsoft.AspNetCore.SuppressSameSiteNone compat key * Patchconfig * Port CookiePolicy fix
DO NOT MERGE. There is a seperate PR for 3.0 (#13870) and it needs to wait until the branch opens for November. |
On a side-note, it seems that the bot that generates this is only looking at the Git "Committer" field. Perhaps it should consider the "Author" field. In this case, I just pressed the merge button on @Tratcher 's commits. @Tratcher is more likely to have the context here for conflict resolution. |
On the same side note, this isn't our bot but we can bring the author preference up with dnceng. Wanna file a bug in dotnet/core-eng? |
Unblocked, but we need to be careful about resolving the merge conflicts. |
Why is this unblocked while we're still trying to get 3.0.1 done? Are the changes coming in mandatory for 3.01? Separately, will the "we" in your statement about conflict resolution be "@Tratcher"? We need an owner and if it's not you, the assignee for this PR is incorrect. |
I've resolved the conflicts. |
I detected changes in the release/2.2 branch which have not been merged yet to release/3.0. I'm a robot and am configured to help you automatically keep release/3.0 up to date, so I've opened this PR.
This PR merges commits made on release/2.2 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/2.2-to-release/3.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.