Skip to content

[automated] Merge branch 'release/2.2' => 'release/3.0' #14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/2.2 branch which have not been merged yet to release/3.0. I'm a robot and am configured to help you automatically keep release/3.0 up to date, so I've opened this PR.

This PR merges commits made on release/2.2 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/2.2
git pull --ff-only
git checkout release/3.0
git pull --ff-only
git merge --no-ff release/2.2

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-release/3.0
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-release/3.0

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/2.2-to-release/3.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/2.2-to-release/3.0 release/3.0
git pull https://github.com/dotnet-maestro-bot/AspNetCore merge/release/2.2-to-release/3.0
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-release/3.0
or if you are using SSH
git checkout -b merge/release/2.2-to-release/3.0 release/3.0
git pull [email protected]:dotnet-maestro-bot/AspNetCore merge/release/2.2-to-release/3.0
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/2.2-to-release/3.0

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

dougbu and others added 3 commits October 3, 2019 12:32
* Re-implement SameSite for 2019 dotnet#12125

* Rename compat flag

* Use Microsoft.AspNetCore.SuppressSameSiteNone compat key

* Backport CookiePolicy quirk and sample

* Patch config
* Re-implement SameSite for 2019 dotnet#12125

* Rename compat flag

* References

* Use Microsoft.AspNetCore.SuppressSameSiteNone compat key

* Patchconfig

* Port CookiePolicy fix
@Tratcher
Copy link
Member

Tratcher commented Oct 3, 2019

DO NOT MERGE.

There is a seperate PR for 3.0 (#13870) and it needs to wait until the branch opens for November.

@Tratcher Tratcher self-assigned this Oct 3, 2019
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 3, 2019
@Tratcher Tratcher changed the title [automated] Merge branch 'release/2.2' => 'release/3.0' [automated][DO NOT MERGE] Merge branch 'release/2.2' => 'release/3.0' Oct 4, 2019
@dotnet-maestro-bot
Copy link
Contributor Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@analogrelay
Copy link
Contributor

This PR merges commits made on release/2.2 by the following committers:

On a side-note, it seems that the bot that generates this is only looking at the Git "Committer" field. Perhaps it should consider the "Author" field. In this case, I just pressed the merge button on @Tratcher 's commits. @Tratcher is more likely to have the context here for conflict resolution.

@dougbu
Copy link
Contributor

dougbu commented Oct 8, 2019

On the same side note, this isn't our bot but we can bring the author preference up with dnceng. Wanna file a bug in dotnet/core-eng?

@analogrelay
Copy link
Contributor

@rynowak rynowak added the blocked The work on this issue is blocked due to some dependency label Oct 8, 2019
@Tratcher Tratcher changed the title [automated][DO NOT MERGE] Merge branch 'release/2.2' => 'release/3.0' [automated] Merge branch 'release/2.2' => 'release/3.0' Oct 9, 2019
@Tratcher Tratcher removed the blocked The work on this issue is blocked due to some dependency label Oct 9, 2019
@Tratcher
Copy link
Member

Tratcher commented Oct 9, 2019

Unblocked, but we need to be careful about resolving the merge conflicts.

@dougbu
Copy link
Contributor

dougbu commented Oct 9, 2019

Unblocked, but we need to be careful about resolving the merge conflicts.

Why is this unblocked while we're still trying to get 3.0.1 done? Are the changes coming in mandatory for 3.01?

Separately, will the "we" in your statement about conflict resolution be "@Tratcher"? We need an owner and if it's not you, the assignee for this PR is incorrect.

@Tratcher
Copy link
Member

Tratcher commented Oct 9, 2019

I've resolved the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants