Skip to content

Update Facebook API to 4.0 #14798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Update Facebook API to 4.0 #14798

merged 1 commit into from
Oct 17, 2019

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Oct 7, 2019

#4684 Every release we update our OAuth providers to make sure they're referencing the latest 3rd party API endpoints. Facebook is the only one that appears out of date this time. No behavior changes were observed when changing the version.

@Tratcher Tratcher added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Oct 7, 2019
@Tratcher Tratcher added this to the 3.1.0-preview2 milestone Oct 7, 2019
@Tratcher Tratcher requested review from analogrelay and HaoK October 7, 2019 18:31
@Tratcher Tratcher self-assigned this Oct 7, 2019
@Tratcher
Copy link
Member Author

Tratcher commented Oct 8, 2019

@aspnet-hello
Copy link

@analogrelay
Copy link
Contributor

analogrelay commented Oct 8, 2019

Chasing Auth APIs like...

Charlie Brown, from the Peanuts comic strip, runs down a field to kick a football that Lucy is holding. When he reaches the football, Lucy pulls it away at the last minute. Charlie Brown goes flying into the air and falls down on his back.

@Tratcher
Copy link
Member Author

Tratcher commented Oct 8, 2019

@Pilchie for approval.

@analogrelay
Copy link
Contributor

analogrelay commented Oct 8, 2019

I endorse this for 3.1. There is no user-facing change, this is just some future-proofing to ensure we use the most recent version. The version number is for the entire Facebook API as a whole. There are no breaking changes to auth in the 4.0 API, so we are migrating to that endpoint. The 3.3 endpoints will stop working July, 2021 (https://developers.facebook.com/docs/graph-api/changelog/version3.3) which is before 3.1 will be out-of-support, so we'd like to get on the latest.

We do also allow users to change these endpoints manually (for example, if 4.0 goes out of support during 3.1's lifetime) but we want the defaults to Just Work:tm:

@Tratcher Tratcher requested a review from Pilchie October 14, 2019 20:01
@Tratcher Tratcher merged commit 90b42ba into release/3.1 Oct 17, 2019
@Tratcher Tratcher deleted the tratcher/3.1/facebook branch October 17, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants