Skip to content

Rename class "error-ui" to "blazor-error-ui" #14887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Rename class "error-ui" to "blazor-error-ui" #14887

merged 1 commit into from
Oct 10, 2019

Conversation

adrianwright109
Copy link
Contributor

Follow up PR to #14636

cc @SteveSandersonMS

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Oct 10, 2019
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, less likely to conflict with existing classes.

@ryanbrandenburg
Copy link
Contributor

Looks like an unrelated test failed due to flakiness. I'm retrying now.

@ryanbrandenburg
Copy link
Contributor

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2483

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb - thanks!

@SteveSandersonMS SteveSandersonMS merged commit 0cf0587 into dotnet:release/3.1 Oct 10, 2019
@adrianwright109 adrianwright109 deleted the rename-css-error-ui-to-blazor-error-ui branch October 11, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants