Skip to content

Add Ability to Tweak JWT Refresh Intervals #14909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2019
Merged

Add Ability to Tweak JWT Refresh Intervals #14909

merged 6 commits into from
Oct 28, 2019

Conversation

say25
Copy link
Contributor

@say25 say25 commented Oct 11, 2019

Summary of the changes (Less than 80 chars)

  • Add Ability to Tweak JWT Refresh Intervals

@Tratcher Tratcher added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Oct 11, 2019
@Tratcher
Copy link
Member

  • The release/3.0 branch is not open, please retarget to master.
  • Adding new APIs requires updating reference assemblies, but don't do that yet, I expect we'll have feedback about the names.

@Tratcher
Copy link
Member

Is this intended to help address #13046? Or some other active issue?

@Tratcher
Copy link
Member

@Tratcher Tratcher self-assigned this Oct 11, 2019
@say25 say25 changed the base branch from release/3.0 to master October 11, 2019 04:14
@say25 say25 changed the base branch from master to release/3.0 October 11, 2019 04:15
@say25 say25 changed the base branch from release/3.0 to master October 11, 2019 14:23
@say25
Copy link
Contributor Author

say25 commented Oct 11, 2019

If we're going to do this it should also be done for OpenIdConnect.
https://github.com/aspnet/AspNetCore/blob/bcc962a182a273cdaa7de474528e97913373a212/src/Security/Authentication/OpenIdConnect/src/OpenIdConnectOptions.cs#L132

Done

  • The release/3.0 branch is not open, please retarget to master.
  • Adding new APIs requires updating reference assemblies, but don't do that yet, I expect we'll have feedback about the names.

Done

Is this intended to help address #13046? Or some other active issue?

Partially though I'm basically trying to use the simple services.AddAuthentication().AddJwtBearer method and tweak these values

@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Oct 11, 2019
@Tratcher Tratcher added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Oct 15, 2019
@Tratcher
Copy link
Member

What kind of build issues? The "Build Code Check" build is asking you to update the reference assemblies.

@say25
Copy link
Contributor Author

say25 commented Oct 16, 2019

When I try to run Regenerate reference assemblies for all projects Run .\eng\scripts\GenerateReferenceAssemblies.ps1 from repository root.

I get a bunch of errors like:

D:\work\Github\AspNetCore\src\ProjectTemplates\Web.Spa.ProjectTemplates\Microsoft.DotNet.Web.Spa.ProjectTemplates.cspro
j : error MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be found.
D:\work\Github\AspNetCore\src\ProjectTemplates\testassets\DotNetToolsInstaller\DotNetToolsInstaller.csproj(4,31): error
 MSB4236: The SDK 'Microsoft.NET.Sdk' specified could not be found.

@Tratcher
Copy link
Member

Make sure you run restore.cmd first.

@say25
Copy link
Contributor Author

say25 commented Oct 16, 2019

Building of C# project is enabled and has dependencies on NodeJS projects. Building of NodeJS projects is enabled since node is detected in C:\Program Files.
Detected JDK in C:\Program Files\Java\jdk1.8.0_211 (via JAVA_HOME)
  It was not possible to find any installed .NET Core SDKs
  Did you mean to run .NET Core SDK commands? Install a .NET Core SDK from:
      https://aka.ms/dotnet-download
C:\Users\syeh\.nuget\packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19462.4\tools\Tools.proj : error : Unable to locat
e the .NET Core SDK. Check that it is installed and that the version specified in global.json (if any) matches the inst
alled version.
C:\Users\syeh\.nuget\packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19462.4\tools\Tools.proj : error MSB4236: The SDK
'Microsoft.NET.Sdk' specified could not be found.
Build failed.

@Tratcher
Copy link
Member

Hmm, thanks for trying. It's working locally for me so I updated the refs and pushed to your branch.

@say25
Copy link
Contributor Author

say25 commented Oct 16, 2019

Thanks. Out of curiosity. Will this get backported to 3.X?

@Tratcher
Copy link
Member

Tratcher commented Oct 16, 2019

Thanks. Out of curiosity. Will this get backported to 3.X?

Unlikely, this doesn't unblock any critical scenarios, it just makes existing scenarios slightly easier.

@Tratcher
Copy link
Member

@Tratcher
Copy link
Member

@blowdart for triage today.

@analogrelay analogrelay added api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Oct 17, 2019
@analogrelay
Copy link
Contributor

@aspnet/asp-net-api-reviews @davidfowl @rynowak API review pls

@Tratcher
Copy link
Member

ping @aspnet/asp-net-api-reviews @davidfowl @rynowak API review pls

@Tratcher Tratcher requested a review from a team October 25, 2019 16:28
@Tratcher
Copy link
Member

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/3297

@pranavkm pranavkm added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews labels Oct 28, 2019
@Tratcher Tratcher merged commit ec4a7f6 into dotnet:master Oct 28, 2019
@Tratcher
Copy link
Member

Thanks

@say25 say25 deleted the Allow-Tweaking-JWT-Refreshes branch October 29, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-approved API was approved in API review, it can be implemented area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants