Skip to content

Make ApiDescriptionActionData public #15023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

Make ApiDescriptionActionData public #15023

merged 2 commits into from
Oct 16, 2019

Conversation

tebeco
Copy link
Contributor

@tebeco tebeco commented Oct 15, 2019 •
edited
Loading

(I have no idea if i took the proper branch, i started on 3.0, and i wonder if i should have took 3.1.0-preview1

Summary of the changes

  • Make ApiDescriptionActionData public back

Addresses #14954 (suggested by @pranavkm / @mkArtakMSFT )
see domaindrivendev/Swashbuckle.AspNetCore#1316 (comment)

I have no idea if the scaffolding should change of if there's anything else to add on top of this

@tebeco tebeco changed the base branch from master to release/3.1-preview1 October 15, 2019 17:13
@tebeco tebeco changed the base branch from release/3.1-preview1 to release/3.0 October 15, 2019 17:13
@pranavkm pranavkm changed the base branch from release/3.0 to release/3.1 October 15, 2019 17:28
@pranavkm
Copy link
Contributor

@tebeco could you cherry-pick your changes on the release/3.1 branch? 3.0 has already shipped and we can not add new APIs to it.

@tebeco
Copy link
Contributor Author

tebeco commented Oct 15, 2019

@pranavkm , done

@pranavkm
Copy link
Contributor

Thanks @tebeco. Could you also update the reference assembly in Microsoft.AspNetCore.Mvc.Core. See https://github.com/aspnet/AspNetCore/blob/master/docs/ReferenceAssemblies.md#when-changing-public-api

@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 15, 2019
@tebeco
Copy link
Contributor Author

tebeco commented Oct 16, 2019 •
edited
Loading

out of curiousity, what is Helix :D ?

https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.Helix/Sdk ?

Should i worry about these build ? anything that i should do to fix it ?

javiercn
javiercn approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @pranavkm for final sign-off. It's my understanding we want to take this.

@pranavkm pranavkm merged commit 49191f4 into dotnet:release/3.1 Oct 16, 2019
@pranavkm
Copy link
Contributor

Thanks @tebeco!

@tebeco tebeco deleted the make-ApiDescriptionActionData-public branch October 16, 2019 16:43
@pranavkm pranavkm added this to the 3.1.0-preview2 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
3.1.0-preview2
Development

Successfully merging this pull request may close these issues.
4 participants
@tebeco @pranavkm @javiercn @mkArtakMSFT