Skip to content

[release/3.0] Pin Microsoft.Internal.Extensions.Refs #15062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Oct 16, 2019

This is not being produced in current 3.0 builds so the coherent parent dependency attribute cannot be satisfied.

This is not being produced in current 3.0 builds so the coherent parent dependency attribute cannot be satisfied.
@mmitche mmitche requested a review from dougbu as a code owner October 16, 2019 16:15
@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 16, 2019
@mmitche mmitche requested a review from wtgodbe October 16, 2019 17:02
@@ -281,7 +281,7 @@
<Uri>https://github.com/aspnet/Extensions</Uri>
<Sha>0b951c16de0f39e13cce8372e11c28eb90576662</Sha>
</Dependency>
<Dependency Name="Microsoft.Internal.Extensions.Refs" Version="3.0.0-rc2.19463.5" CoherentParentDependency="Microsoft.EntityFrameworkCore">
<Dependency Name="Microsoft.Internal.Extensions.Refs" Version="3.0.0-rc2.19463.5" CoherentParentDependency="Microsoft.EntityFrameworkCore" Pinned="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the CoherentParentDependency attribute. We've had trouble w/ pinning packages that are included in the coherency graph.

@mmitche mmitche merged commit 5ceb94f into dotnet:release/3.0 Oct 16, 2019
@mmitche mmitche deleted the pin-internal-refs branch October 16, 2019 21:24
@analogrelay analogrelay added this to the 3.0.1 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants