Handle large limits for form keys and values #15066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
Oct 16, 2019
jkotalik
approved these changes
Oct 16, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13719 This addresses a 3.0 regression in the form parser where two limits were added together and could overflow if large values were used. We have several customers report that they effectively disable these limits by setting int.MaxValue (against our recommendations), but in 3.0 this results in the limits being treated as negative and always failing.
The limits are added together in this scenario because the algorithm attempts to find the dividing '&' before it searches internally for the optional '='. This only happens when a key=value pair spans multiple reads from the pipe.