Skip to content

Flow return url in register confirmation #15075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2019
Merged

Flow return url in register confirmation #15075

merged 3 commits into from
Oct 17, 2019

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Oct 16, 2019

Fixes #14998

@HaoK HaoK requested review from ajcvickers and javiercn October 16, 2019 17:35
@HaoK HaoK added this to the 3.1.0-preview2 milestone Oct 16, 2019
@HaoK HaoK added the area-identity Includes: Identity and providers label Oct 16, 2019
javiercn
javiercn approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

nit: As an aside, would it make sense to have an instantiation of the templates on the samples folder so that these things can be easily validated E2E?

@HaoK
Copy link
Member Author

HaoK commented Oct 16, 2019

RE templates validation, yeah I was wondering about that too, but maybe we should just have a few E2E tests in the templates directory, similar to your SPA template test?

@HaoK HaoK merged commit 5dfb923 into release/3.1 Oct 17, 2019
@HaoK HaoK deleted the identity-return branch October 17, 2019 20:04
@HaoK HaoK mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
3.1.0-preview2
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @javiercn