Skip to content

[Blazor] Fixes reliability issues in the blazor reliability tests #15223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Oct 21, 2019

System.Exception : Timed out while waiting for batch.
...
Debug: CompletingBatchWithoutError Completing batch 2 without error in 10059.9243ms.

The error is self-explanatory, it times out waiting for the batch after 10 seconds, and the batch takes a bit more than 10 seconds to render. Likely due to a spike in the machine load.

Addresses https://github.com/aspnet/AspNetCore-Internal/issues/3173 among others.

Some tests get stuck when run on the CI likely due to spikes on the CI machine load. This fix doubles the startup timeout of the reliability tests to account for that.
@javiercn javiercn requested a review from pranavkm October 21, 2019 15:55
@javiercn javiercn added the area-blazor Includes: Blazor, Razor Components label Oct 21, 2019
@javiercn javiercn merged commit 08608af into release/3.1 Oct 22, 2019
@javiercn javiercn deleted the javiercn/improve-js-reliability-timeouts-1 branch October 22, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants