Use MinimumOSVersion in Kestrel #15228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
approved these changes
Oct 21, 2019
|
There are many of these in IIS? Want to do them there as well? |
Those are all Win7, right? I'm starting a separate conversation to figure out what to do about that. |
|
@jkotalik here's the only relevant IIS Win8 reference I can find. |
jkotalik
added
the
tell-mode
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anurse Test only change.
Some tests require specific versions of Win10 and we recently added support for detecting that via MinimumOSVersion. We'd also like to move away from using OSSkipCondition for version checks, only using it for platform checks instead.
I also adjusted the APLN related skips to clarify that Win8 does not support it.
I'll need to make some additional reactions in master where some of these conditions were changed.
#14382