[3.1] Update Grpc.AspNetCore to 2.24.0 #15245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
reviewed
Oct 21, 2019
| @@ -236,7 +236,7 @@ | |||
| <CastleCorePackageVersion>4.2.1</CastleCorePackageVersion> | |||
| <FSharpCorePackageVersion>4.2.1</FSharpCorePackageVersion> | |||
| <GoogleProtobufPackageVersion>3.8.0</GoogleProtobufPackageVersion> | |||
| <GrpcAspNetCorePackageVersion>2.23.2</GrpcAspNetCorePackageVersion> | |||
| <GrpcAspNetCorePackageVersion>2.24.0</GrpcAspNetCorePackageVersion> | |||
There was a problem hiding this comment.
More specifically, how do the fixes in https://github.com/grpc/grpc-dotnet/releases/tag/v2.24.0-pre1 affect the gRPC features of this repo?
There was a problem hiding this comment.
Updated customer impact.
|
I approve for Preview 2. After that, the bar might be too high for 3.1 without fixes that impact a significant number of users. |
JunTaoLuo
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Grpc.AspNetCore reference in gRPC template to 2.24.0.
Customer impact
2.24.0 fixes a number of issues found in the initial gRPC release that have been reported by customers. Release notes: https://github.com/grpc/grpc-dotnet/releases/tag/v2.24.0-pre1
This PR updates the template so new gRPC projects get a version of gRPC with fixes by default.
Regression
No
Risk
Low