Skip to content

Don't access CookieContainer unless needed #16619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2019
Merged

Conversation

BrennanConroy
Copy link
Member

While experimenting with blazor-webassembly and the SignalR C# Client I found that this is the only blocking (not-user fixable) issue for consuming the client with the LongPolling transport.

We set the _httpConnectionOptions.Cookies property to a new object in the HttpConnectionOptions constructor, so by default it isn't null and will access the httpClientHandler.CookieContainer property which will throw in mono wasm.

We want this for 3.1 because blazor-wasm is scheduled for May 2020 and we would like the SignalR Client to work at that time.

No tests because this isn't unit-testable without making a full end-to-end blazor-wasm + signalr test suite.

@Pilchie for 3.1 approval

@BrennanConroy BrennanConroy added area-signalr Includes: SignalR clients and servers Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together labels Oct 28, 2019
@BrennanConroy BrennanConroy added this to the 3.1.0-preview3 milestone Oct 28, 2019
Co-Authored-By: Andrew Stanton-Nurse <[email protected]>
@Pilchie
Copy link
Member

Pilchie commented Oct 28, 2019

Approved for 3.1.0-preview3, pending CI build and code review approvals

@analogrelay
Copy link
Contributor

analogrelay commented Oct 28, 2019

I'm glad it was a pretty straightforward set of changes needed!

@BrennanConroy can you add a Blazor WASM sample to the repo? That way we have at least some idea of the changes a user has to make currently in order to get it to work.

@BrennanConroy
Copy link
Member Author

@BrennanConroy can you add a Blazor WASM sample to the repo?

I'm going to vote for no right now. There is a lot of churn with the HttpClientHandler right now see: #16631 so this would break as soon as I made it

@halter73
Copy link
Member

How afraid are we of temporarily broken samples are we really? If you already have a working sample, I say check it in. Then when the API stabilizes, we can fix the sample instead of creating a new one from scratch.

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Oct 31, 2019

I tried to add the sample, but it appears to be non-trivial and I wont have any more time to try until after preview3.

Please approve (assuming the change is good :D)

@BrennanConroy
Copy link
Member Author

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/3261
https://github.com/aspnet/AspNetCore-Internal/issues/3241

@BrennanConroy BrennanConroy merged commit cd09f74 into release/3.1 Nov 1, 2019
@BrennanConroy BrennanConroy deleted the brecon/blasm branch November 1, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers Blazor ♥ SignalR This issue is related to the experience of Signal R and Blazor working together
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants