Suppress log when request is cancelled #16691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahbazi
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
Tratcher
requested changes
Oct 31, 2019
jkotalik
reviewed
Nov 20, 2019
| if (!RequestContext.DisconnectToken.IsCancellationRequested) | ||
| { | ||
| // This is logged rather than thrown because it is too late for an exception to be visible in user code. | ||
| LogHelper.LogError(Logger, "ResponseStream::Dispose", "Fewer bytes were written than were specified in the Content-Length."); |
There was a problem hiding this comment.
@Kahbazi can you write a unit test to verify this behavior? Or is there a race and it makes it hard to write a test.
There was a problem hiding this comment.
I plan to try some manual verification before merging this. I don't know if DisconnectToken.IsCancellationRequested is consistent enough in these scenarios for this to work as expected.
Tratcher
approved these changes
Nov 20, 2019
|
Thanks |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8696