Skip to content

Pin Microsoft.NETCore.App.Ref #16707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2019
Merged

Pin Microsoft.NETCore.App.Ref #16707

merged 2 commits into from
Nov 1, 2019

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 31, 2019
@JunTaoLuo JunTaoLuo added this to the 3.0.1 milestone Oct 31, 2019
@JunTaoLuo JunTaoLuo requested a review from wtgodbe October 31, 2019 20:07
@JunTaoLuo JunTaoLuo requested a review from dougbu as a code owner October 31, 2019 20:07
nguerrera
nguerrera reviewed Oct 31, 2019
View reviewed changes
@mmitche
Copy link
Member

mmitche commented Oct 31, 2019

I don't think maestro will touch it if it's pinned, so putting the right sha is needed.

@JunTaoLuo JunTaoLuo merged commit 80ff7fd into release/3.0 Nov 1, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/pin-netcore-ref branch November 1, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguerrera nguerrera nguerrera approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@JunTaoLuo @mmitche @nguerrera @wtgodbe